Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of podman.podman_login #249

Closed
wants to merge 2 commits into from

Conversation

dometto
Copy link
Contributor

@dometto dometto commented Mar 12, 2024

See #248. This reverts the changes made to podman registry login step in e9d5649 b, ensuring that we can use the podman plugin while we wait for a reply in containers/ansible-podman-collections#723

@github-actions github-actions bot added the bug Something isn't working label Mar 12, 2024
@dometto
Copy link
Contributor Author

dometto commented Mar 12, 2024

I've also added a commit that sets no_log to true for the login command. This was presumably handled by the podman.podman_login module itself, but since this PR now uses ansible.command again, I felt it would be better to suppress all login output to obscure the password, analogous to the docker plugin.

@dometto
Copy link
Contributor Author

dometto commented Mar 12, 2024

Closing in favour of #250

@dometto dometto closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant