-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass at a GitHub Pages publishing shared workflow #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging right away because:
|
This was referenced May 1, 2022
Closes #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reusable workflow for publishing to GitHub Pages.
This is intended to be an opinionated, specific way of doing so that supports multiple simultaneous docs builds within a single GitHub Pages site, not a general workflow to have a high degree of customizability.
The reason for that, is that the bulk of the "work" of publishing to GH pages is handled by a single action, peaceiris/actions-gh-pages, which can be used directly for anyone wishing to do something simpler or more custom. Alternatively, "publishing" to GitHub Pages is done via commit and push, so users who don't want to use the action can similarly put something together using git commands.
Or this workflow can have the
destination-dir
overridden, which is really where our convention is applied.About the convention used
When
destination-dir
is not set, this workflow puts docs into sub-directories in the published site based on the event:/pr/XX
whereXX
is the PR number, for example:/pr/123
/branch/NAME
, for example:/branch/main
or/branch/stable-3
/tag/TAG
, for example:/tag/3.21.7
Since the consumer of the workflow completely controls the triggers of their calling workflow, anyone who wants to limit which sites get published can do so by limiting the workflow triggers (triggering on only PRs or pushes, limiting the branches and tags, etc.); this does not need customization in the workflow.
I will post a getting started guide to initially setting up GH pages, but it is pretty straightforward.
Not supported
Also, right now there's no straightforward way to have this publish arbitrary branches/tags that were pushed before this was in place. It can be done (in the consuming repo) by adding a
workflow_dispatch
trigger with an input of the branch or tag, and then you'd have to setdestination-dir
yourself following the convention. That would work for one-at-a-time. For outside of actions, some separate script could render all the docs for the various refs, put them in the correct directories, and push them up.