Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --collection-dir apply only to 'collection' and 'build-collection' subcommands #461

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Make --collection-dir apply only to 'collection' and 'build-collection' subcommands #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9e3189
Make --collection-dir apply only to 'collection' and 'build-collectio…
felixfontein Nov 16, 2022
7cb81e1
Rewrite changelog.
felixfontein Nov 17, 2022
4dfa57c
Update changelogs/fragments/461-collection-dir.yml
felixfontein Nov 17, 2022
7a4cc6b
Update changelogs/fragments/461-collection-dir.yml
felixfontein Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/461-collection-dir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "Add ``--collection-dir`` to the ``antsibull-build`` ``collection`` and ``build-collection`` subcommands. Previously, the ``--collection-dir`` option was added to the wrong CLI argument parser and not exposed to users. (https://github.com/ansible-community/antsibull/pull/461)."
4 changes: 2 additions & 2 deletions src/antsibull/cli/antsibull_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ def parse_args(program_name: str, args: List[str]) -> argparse.Namespace:
' versions which were included in this version of Ansible.'
' This is considered to be relative to --data-dir.'
f' The default is {DEFAULT_FILE_BASE}-X.Y.Z.deps')
build_parser.add_argument('--collection-dir', default='.',
help='Directory to write collection to')
collection_parser.add_argument('--collection-dir', default='.',
help='Directory to write collection to')

subparsers.add_parser('changelog',
parents=[build_write_data_parser, cache_parser],
Expand Down