Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removed collection information from previous major releases #174

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

felixfontein
Copy link
Collaborator

This allows to improve ansible-community/antsibull-docs#341 to also create stubs for collections removed in older major Ansible releases.

@felixfontein
Copy link
Collaborator Author

How the data could look like: ansible-community/ansible-build-data#465

@gotmax23
Copy link
Collaborator

gotmax23 commented Oct 7, 2024

We should probably have a policy re. how long we keep these tombstones around. Also, would it make sense to read removed_collections from previous releases instead?

@felixfontein
Copy link
Collaborator Author

We should probably have a policy re. how long we keep these tombstones around.

True. Right now I'd say "until we decide we have to clean up", since that data doesn't take up much space. But in 10 years or so some cleanup might not hurt :)

Also, would it make sense to read removed_collections from previous releases instead?

To avoid having to read data from more than one directory in ansible-build-data. At some point I'd like every Ansible release's sdist to contain all metadata needed to rebuild itself, so you don't have to clone a specific tag of the ansible-build-data repo. For that to be feasible only the contents (resp. a subset of them) of one directory in ansible-build-data should be included.

@gotmax23
Copy link
Collaborator

gotmax23 commented Oct 8, 2024

We should probably have a policy re. how long we keep these tombstones around.

True. Right now I'd say "until we decide we have to clean up", since that data doesn't take up much space. But in 10 years or so some cleanup might not hurt :)

I think we should at least have some set amount of time and potentially print a warning message if the removed_collections entries are too old. Maybe ask the SC or DAWGs for their opinions about how long to keep the tombstones around?

Also, would it make sense to read removed_collections from previous releases instead?

To avoid having to read data from more than one directory in ansible-build-data.

Fair enough. I guess if we're just cping the collection-meta file from one directory to another during the new major release process, it's not a big deal to keep removed_collections entries from the previous release.

@felixfontein felixfontein merged commit 4f65622 into ansible-community:main Oct 8, 2024
5 checks passed
@felixfontein felixfontein deleted the removals branch October 8, 2024 18:56
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants