Remove deprecated servicenow.servicenow from Ansible 9 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariolenz
force-pushed
the
remove_servicenow
branch
from
9198476
to
bb33a2d
Compare
felixfontein
requested changes
Jun 23, 2023
8/ansible-8.build
Outdated
| @@ -99,7 +99,6 @@ purestorage.flasharray: >=1.18.0,<2.0.0 | |||
| purestorage.flashblade: >=1.11.0,<2.0.0 | |||
| purestorage.fusion: >=1.4.0,<2.0.0 | |||
| sensu.sensu_go: >=1.13.0,<2.0.0 | |||
| servicenow.servicenow: >=1.0.0,<2.0.0 | |||
There was a problem hiding this comment.
The collection MUST NOT be removed from Ansible 8. This is a breaking change and thus not acceptable since Ansible sticks to semantic versioning.
There was a problem hiding this comment.
I don't think this is the only place we have to change in this case... let me have a look and do another commit.
There was a problem hiding this comment.
@felixfontein I think it should be OK now.
mariolenz
force-pushed
the
remove_servicenow
branch
from
a844959
to
dbaaa9e
Compare
mariolenz
changed the title
|
@felixfontein BTW if you think this change is OK now and there's no need to discuss it in the next meeting, feel free to remove the |
Co-authored-by: Felix Fontein <[email protected]>
mariolenz
changed the title
felixfontein
approved these changes
Jun 24, 2023
|
Thanks a lot for fixing this! I really wonder how that collection managed to sneak back in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ansible-community/community-topics#246 for more information.