Fix for long computer names (#114)

* Fix for long computer names * Added changelog fragement and improve tests --------- Co-authored-by: Jordan Borean <[email protected]>
ansible-collections · Apr 29, 2024 · 88575f9 · 88575f9
1 parent a7b214f
commit 88575f9
Show file tree

Hide file tree

Showing 3 changed files with 239 additions and 36 deletions.
diff --git a/changelogs/fragments/membership-long-name.yml b/changelogs/fragments/membership-long-name.yml
@@ -0,0 +1,4 @@
+bugfixes:
+  - >-
+    microsoft.ad.membership - Fix hostname check to work with hostnames longer than 15 characters long -
+    https://github.com/ansible-collections/microsoft.ad/issues/113
diff --git a/plugins/modules/membership.ps1 b/plugins/modules/membership.ps1
@@ -143,7 +143,7 @@ Function Get-CurrentState {
     }
 
     [PSCustomObject]@{
-        HostName = $env:COMPUTERNAME
+        HostName = [System.Net.Dns]::GetHostName()
         PartOfDomain = $cs.PartOfDomain
         DnsDomainName = $domainName
         WorkgroupName = $cs.Workgroup