Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add pass-credentials key #282

Merged
merged 7 commits into from
Nov 19, 2021
Merged

helm: add pass-credentials key #282

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61ec1d8
add pass-credentials key
Nov 15, 2021
a084b56
update changelog
Nov 17, 2021
202191e
add changelogs fragment
Nov 17, 2021
dc9395b
revert changelog.rst
Nov 17, 2021
bc5db23
add newline at the end of file
Nov 17, 2021
c01463a
black formatting
Nov 17, 2021
6cb8288
add trailing commas
Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions plugins/modules/helm_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@
default: present
aliases: [ state ]
type: str
pass_credentials:
description:
- Pass credentials to all domains.
required: false
default: false
type: boolean
nkromano marked this conversation as resolved.
Show resolved Hide resolved
nkromano marked this conversation as resolved.
Show resolved Hide resolved
"""

EXAMPLES = r"""
Expand Down Expand Up @@ -157,14 +163,17 @@ def get_repository_status(module, command, repository_name):

# Install repository
def install_repository(
command, repository_name, repository_url, repository_username, repository_password
command, repository_name, repository_url, repository_username, repository_password, pass_credentials
nkromano marked this conversation as resolved.
Show resolved Hide resolved
):
install_command = command + " repo add " + repository_name + " " + repository_url

if repository_username is not None and repository_password is not None:
install_command += " --username=" + repository_username
install_command += " --password=" + repository_password

if pass_credentials:
install_command += " --pass-credentials"

return install_command


Expand All @@ -188,6 +197,7 @@ def main():
repo_state=dict(
default="present", choices=["present", "absent"], aliases=["state"]
),
pass_credentials=dict(type="bool", default=False)
nkromano marked this conversation as resolved.
Show resolved Hide resolved
),
required_together=[["repo_username", "repo_password"]],
required_if=[("repo_state", "present", ["repo_url"])],
Expand All @@ -205,6 +215,7 @@ def main():
repo_username = module.params.get("repo_username")
repo_password = module.params.get("repo_password")
repo_state = module.params.get("repo_state")
pass_credentials = module.params.get("pass_credentials")

if bin_path is not None:
helm_cmd = bin_path
Expand All @@ -219,7 +230,7 @@ def main():
elif repo_state == "present":
if repository_status is None:
helm_cmd = install_repository(
helm_cmd, repo_name, repo_url, repo_username, repo_password
helm_cmd, repo_name, repo_url, repo_username, repo_password, pass_credentials
nkromano marked this conversation as resolved.
Show resolved Hide resolved
)
changed = True
elif repository_status["url"] != repo_url:
Expand Down