Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin_version parameter for helm_plugin module #226

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 7, 2021

SUMMARY

closes #157

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@abikouo abikouo closed this Sep 8, 2021
@abikouo abikouo reopened this Sep 8, 2021
@abikouo
Copy link
Contributor Author

abikouo commented Sep 9, 2021

recheck

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

plugins/modules/helm_plugin.py Outdated Show resolved Hide resolved
plugins/modules/helm_plugin.py Outdated Show resolved Hide resolved
plugins/modules/helm_plugin.py Outdated Show resolved Hide resolved
@abikouo
Copy link
Contributor Author

abikouo commented Sep 28, 2021

@Akasurde changes requested have been resolved, could you please review/approve ? Thanks

Copy link

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit ab0e387 into ansible-collections:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to set version for helm_plugin
3 participants