Fix bug to handle duplicate subnet across different vpc networks #561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
GCP doesn't allow to create any subnet with the same name in the same region if already exists in any other VPC network, but the original ansible module gcp_compute_subnetwork doesn't throw an error. So this PR suggests adding a condition check in the module and error out for this scenario.
Fixes #560
ISSUE TYPE
COMPONENT NAME
plugins/modules/gcp_compute_subnetwork.py
ADDITIONAL INFORMATION
GCP API will throw an error if found a duplicated subnet name on another vpc when you are trying to create a same-name subnet. Refer the API guide for details. https://cloud.google.com/compute/docs/reference/rest/v1/subnetworks/insert
This PR suggests adding a condition check to error out the above-mentioned scenario, by comparing the intended vpc network in the request vs the vpc found for the existing subnet, and throw an error if it's a different vpc network.