Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deadLetterPolicy to Pub/Sub Subscription resource #184

Conversation

modular-magician
Copy link
Contributor

Support dead_letter_policy as specified in https://pubsub.googleapis.com/$discovery/rest?version=v1

I've tested changes by applying dead_letter_policy with locally build terraform provider following instructions in README.

Release Note Template for Downstream PRs (will be copied)

pubsub: Added `dead_letter_policy` support to `google_pubsub_subscription`

Fixes hashicorp/terraform-provider-google#5522

Derived from GoogleCloudPlatform/magic-modules#3305

* Add deadLetterPolicy to Pub/Sub subscription resource

* fix: disable allow_empty_objects, fix docstring, add example

* fix: set max_delivery_attempts

* fix: block and topic name

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit c41f599 into ansible-collections:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dead letter policy to pubsub
1 participant