Skip to content

Commit

Permalink
Merge pull request #634 from kuisathaverat/fix/support_more_than_10_v…
Browse files Browse the repository at this point in the history
…ersions

fix: support more than 10 secrets versions on gcp_secret_manager
  • Loading branch information
SirGitsalot authored Aug 1, 2024
2 parents e8bcdf6 + f714022 commit d2aaad7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion plugins/lookup/gcp_secret_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ def get_latest_version(self, module, auth):
self.raise_error(module, f"unable to list versions of secret {response.status_code}")
version_list = response.json()
if "versions" in version_list:
return sorted(version_list['versions'], key=lambda d: d['name'])[-1]['name'].split('/')[-1]
versions_numbers = []
for version in version_list['versions']:
versions_numbers.append(version['name'].split('/')[-1])
return sorted(versions_numbers, key=int)[-1]
else:
self.raise_error(module, f"Unable to list secret versions via {response.request.url}: {response.json()}")

Expand Down
5 changes: 4 additions & 1 deletion plugins/modules/gcp_secret_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,10 @@ def fetch_resource(module, allow_not_found=True):
return None

if "versions" in version_list:
latest_version = sorted(version_list['versions'], key=lambda d: d['name'])[-1]['name'].split('/')[-1]
versions_numbers = []
for version in version_list['versions']:
versions_numbers.append(version['name'].split('/')[-1])
latest_version = sorted(versions_numbers, key=int)[-1]
module.params['calc_version'] = latest_version
else:
# if this occurs, there are no available secret versions
Expand Down

0 comments on commit d2aaad7

Please sign in to comment.