Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of Windows tasks in zabbix_agent #1403

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

meis4h
Copy link
Contributor

@meis4h meis4h commented Oct 11, 2024

SUMMARY

This change cleans up the Windows tasks of the zabbix_agent role and fixes several issues.
No existing functionality is changed or removed (hopefully).

  • Add windows specific version of zabbix_agent_win_controlsocket and zabbix_agent_win_pluginsocket to avoid setting unix default values
  • Add zabbix_win_config_remove variable to optionally prevent deletion of extra configuration inside of zabbix_agent2.d on updates
  • Add loop labels to reduce output clutter
  • Fix detection of currently installed version (solves the same issue as Windows agent installation. #1139 but only noticed the PR while already submitting)
  • Fix usage of zabbix_win_install_dir_ variables throughout all tasks and add temporary "setup" direcory to avoid issues when using different paths
  • Clean up some never used variables and combine some redundant set_facts tasks
  • Avoid unneeded agent restarts which caused errors on some hosts
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zabbix_agent (Windows)

ADDITIONAL INFORMATION

I've verified the changes on Windows Server versions 2016, 2019 and 2022 with Zabbix Agent 1 and 2 on versions 6.0 and 7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant