Refactor TimescaleDB setup/configuration #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I got ahead of myself with moving the timescaledb extension task. Will move it back unless the extension can be enabled by less privileged users. In either case, it needs a small modification. |
|
Is this ready @eb4x |
Nope, sorry about the hold-up. I've converted it to a draft. |
So I guess that answers that, I'll revert the create-extension move. |
Query the db to actually see if we've got timescale configured instead of relying on files. Use the same task for importing the hypertable schema, and just conditionally change the path to the schemas.
In the case that timescale has already been enabled, and we're upgrading from 6.x to 7.x, the auditlog should also get converted. (Which it was not in the 6.x schemas)
pyrodie18
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Just refactor of the timescaledb setup to make configuration more consistent/reliable.
ISSUE TYPE
COMPONENT NAME
zabbix_server