Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Vars #1291

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Clean-up Vars #1291

merged 10 commits into from
Jun 13, 2024

Conversation

pyrodie18
Copy link
Collaborator

SUMMARY

Verified all vars across all roles. Changed all configuration bool vars from 1/0 to true/false. Fixed the problem reported in #1237 .

@pyrodie18 pyrodie18 requested a review from BGmot June 13, 2024 03:23
Copy link
Collaborator

@BGmot BGmot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@pyrodie18 pyrodie18 merged commit 4e2632f into ansible-collections:main Jun 13, 2024
217 checks passed
@pyrodie18 pyrodie18 deleted the fix_vars branch June 13, 2024 23:31
emrocha pushed a commit to emrocha/community.zabbix that referenced this pull request Jul 1, 2024
miettal added a commit to girasolenergy/community.zabbix that referenced this pull request Aug 15, 2024
…onnect

null default for these variables was introduced in ansible-collections#1019. But ansible-collections#1291
dropped this. So currently zabbix_proxy role is not working. This PR
restore past behavior.

see also
 - ansible-collections#1019
 - ansible-collections#1291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants