-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template_yaml parameter to zabbix_template module #1157
Conversation
…YAML to zabbix_template module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
- Coverage 79.75% 79.54% -0.21%
==========================================
Files 34 34
Lines 4307 4278 -29
Branches 1149 1134 -15
==========================================
- Hits 3435 3403 -32
- Misses 517 518 +1
- Partials 355 357 +2 ☔ View full report in Codecov by Sentry. |
I don't have the time to test it right now, but this shouldn't be necessary. The point of the - name: Import Zabbix template from YAML file.
community.zabbix.zabbix_template:
template_json: "{{ lookup('file', 'template4_60_higher.yaml') | from_yaml }}"
state: present
register: import_template_yaml |
@flowerysong Thank you fo your response. I understood it is not necessary. However, it is a temporally workaround that you mentioned way, isn't it? If this pull request is waste, I'll close it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog fragment please?
465924b
to
5db97f9
Compare
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
file
butjson
. Therefore, I cloudn't combinetemplate_XXX
parameter to a parameter.Filter the template json to contain only the keys we will update
infilter_template
function is needed or not. Let me know if need.