Update apache.yml #1053
Merged
Update apache.yml #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "Apache | Enable Site (Debian Only)" task execution conditions by adding 'and zabbix_web_create_vhost'.
|
@pyrodie18 I don't understand why the pull request failed, can you help me to understand please ? |
|
Has nothing to do with you. Its the sanity check. The devel version of ansible requires python 3.10 or higher. We're currently testing on 3.9. If you look at my PR I'm updating it. We'll get you taken care of soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
HINT:
CHANGES:
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
I made this modification because I noticed that when the var "zabbix_web_create_vhost" is set to false, the "Apache | Enable Site (Debian Only)" module is executed in "zabbix_web/tasks/apache.yml", which is a module that should only be executed if the "zabbix_web_create_vhost" variable is set to true, which gives an error when the role is executed. With this small modification, the module no longer executes when the variable parameter is set to false.