Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_host_datastore: Add a new parameter to expand a datastore capacity #915

Merged

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Jun 28, 2021

SUMMARY

This PR will add a new option to expand a datastore capacity.
For example, I think it is a useful parameter in expanding a datastore capacity after increasing LUN capacity with a new enclosure and so on.

Alternative PR from: #913

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/915-vmware_host_datastore.yml
docs/community.vmware.vmware_host_datastore_module.rst
plugins/modules/vmware_host_datastore.py

ADDITIONAL INFORMATION

tested on vCenter/ESXi 7.0.2

@mcarpendale
Copy link

mcarpendale commented Jun 29, 2021

@sky-joker - Tested and working. Thank you. I'll make sure i remove reference to the old PR and the old file vmware_host_datastore_resize.py

@sky-joker
Copy link
Collaborator Author

Thanks, @mcarpendale for taking time to test the module!
I'm glad to hear that the module works well.

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde added the feature_request New feature or request label Jul 12, 2021
@Akasurde Akasurde added this to the v.1.13.0 milestone Jul 12, 2021
@sky-joker
Copy link
Collaborator Author

Thanks, @mariolenz @Akasurde for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants