Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest_controller: Added bus_sharing property to scsi controllers. #878

Merged
merged 7 commits into from
Jun 11, 2021
Merged

vmware_guest_controller: Added bus_sharing property to scsi controllers. #878

merged 7 commits into from
Jun 11, 2021

Conversation

bushvin
Copy link
Contributor

@bushvin bushvin commented Jun 6, 2021 •
edited by sky-joker
Loading

Depends-On: #877

SUMMARY

bus_sharing property have been missing from the module and was added.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_controller

ADDITIONAL INFORMATION

Tested on vcenter 7.0 and 6.7.

@bushvin bushvin mentioned this pull request Jun 6, 2021
Closed
@bushvin bushvin changed the title Patch 1 vmware_guest_controller: Added bus_sharing property to scsi controllers. Jun 6, 2021
@ansibullbot
Copy link

cc @Akasurde @Tomorrow9 @goneri @lparkes @pgbidkar @warthog9
click here for bot help

@ansibullbot ansibullbot added cloud community_review feature This issue/PR relates to a feature request module module needs_triage Needs a first human triage before being processed. new_contributor Help guide this first time contributor plugins plugin (any type) labels Jun 6, 2021
@sky-joker
Copy link
Collaborator

recheck

mariolenz
mariolenz requested changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling I've overlooked something, but don't know what... well here are some some change requests to begin with.

Thanks for this PR @bushvin!

plugins/modules/vmware_guest_controller.py Outdated Show resolved Hide resolved
plugins/modules/vmware_guest_controller.py Outdated Show resolved Hide resolved
plugins/modules/vmware_guest_controller.py Outdated Show resolved Hide resolved
plugins/modules/vmware_guest_controller.py Outdated Show resolved Hide resolved
plugins/modules/vmware_guest_controller.py Outdated Show resolved Hide resolved
@bushvin
Copy link
Contributor Author

bushvin commented Jun 8, 2021

updated and tested.

@bushvin
Copy link
Contributor Author

bushvin commented Jun 8, 2021

it seems the check has failed due to a timeout... :(

@mariolenz
Copy link
Collaborator

recheck

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 9, 2021
@sky-joker
Copy link
Collaborator

recheck

@bushvin bushvin requested a review from mariolenz June 9, 2021 15:13
mariolenz
mariolenz approved these changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz added gate and removed gate labels Jun 11, 2021
@mariolenz mariolenz added the gate label Jun 11, 2021
@ansible-zuul ansible-zuul bot merged commit cd847ef into ansible-collections:main Jun 11, 2021
@mariolenz mariolenz mentioned this pull request Jun 11, 2021
Merged
@bushvin bushvin deleted the patch-1 branch June 15, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde left review comments

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
cloud community_review feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bushvin @ansibullbot @sky-joker @mariolenz @Akasurde