vmware_tag: Modify the category_id parameter to be required for all state #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
cloud
community_review
docs
module
tgates81
approved these changes
Apr 13, 2021
Akasurde
removed
the
needs_triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
According to the module documentation, it is written that the category_id parameter isn't required.
But actually, the module didn't work correctly as for all state(present and absent) that hasn't the parameter.
The category_id also is necessary when removing a tag because it uses in checking a tag status.
This PR will change the parameter to required.
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/790-vmware_tag.yml
docs/community.vmware.vmware_tag_module.rst
plugins/modules/vmware_tag.py
tests/integration/targets/vmware_guest_storage_policy/tasks/main.yml
tests/integration/targets/vmware_tag/tasks/tag_crud_ops.yml
tests/integration/targets/vmware_tag/tasks/tag_manager_duplicate_tag_cat.yml
tests/integration/targets/vmware_vm_storage_policy/tasks/main.yml
ADDITIONAL INFORMATION
tested on vCenter 7.0