Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest_register_operation: An error has been occurring when not specify a datacenter name #693

Merged
merged 3 commits into from
Mar 5, 2021
Merged

vmware_guest_register_operation: An error has been occurring when not specify a datacenter name #693

merged 3 commits into from
Mar 5, 2021

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Mar 3, 2021 •
edited
Loading

SUMMARY

The vmware_guest_register_operation module has been occurring an error when not specifying a datacenter name.
This PR will fix the issue.

fixes: #692

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/693-vmware_guest_register_operation.yml
plugins/modules/vmware_guest_register_operation.py

ADDITIONAL INFORMATION

tested on vCenter/ESXi 7.0

@sky-joker sky-joker mentioned this pull request Mar 3, 2021
Closed
@ansibullbot
Copy link

cc @Akasurde @Tomorrow9 @goneri @lparkes @pgbidkar @warthog9
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud community_review has_issue module module needs_triage Needs a first human triage before being processed. owner_pr PR created by owner/maintainer plugins plugin (any type) labels Mar 3, 2021
@christian-naenny
Copy link

Thanks for fixing this issue so quickly! Looks good to me!

@sky-joker
Copy link
Collaborator Author

@christian-naenny
Thank you for checking this PR!

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 3, 2021
Akasurde
Akasurde approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sky-joker
Copy link
Collaborator Author

Thank you @Akasurde for reviewing!

@sky-joker
Copy link
Collaborator Author

recheck

@Akasurde Akasurde added the gate label Mar 5, 2021
@Akasurde Akasurde added this to the v.1.8.0 milestone Mar 5, 2021
@ansible-zuul ansible-zuul bot merged commit 8899698 into ansible-collections:main Mar 5, 2021
@sky-joker sky-joker deleted the fix_issue692 branch March 7, 2021 14:07
@n3pjk n3pjk mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud community_review has_issue module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
v.1.8.0
4 participants
@sky-joker @ansibullbot @christian-naenny @Akasurde