vmware_dvs_portgroup_find: Fix wrong var type while evaluating vlan and vlanlst #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phsmith
changed the title
|
Since 2020/07/06, the development branch of the |
|
Hello @phsmith, thank you for the PR! Can you please just add a changelog fragment? https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs |
|
It would also be great if you can extend the functional test to cover this problematical use-case, this way we won't reintroduce the issue inadvertently in the future. https://github.com/ansible-collections/vmware/blob/main/tests/integration/targets/vmware_dvs_portgroup_find/tasks/main.yml |
Hello @goneri I'll do that right now. |
Nice @goneri I'll try to do that. |
…ons#45) VMware: vmware_vm_inventory performance improvement Reviewed-by: https://github.com/apps/ansible-zuul
galaxy: define authors and tags keys Reviewed-by: https://github.com/apps/ansible-zuul
Update vmware_guest_disk_info.py Reviewed-by: https://github.com/apps/ansible-zuul
) Handle SSL exception raise in vmware_rest_client Reviewed-by: https://github.com/apps/ansible-zuul
Serialize non-json type objects in hostvars Reviewed-by: https://github.com/apps/ansible-zuul
Update vmware_guest_tools_upgrade.py Reviewed-by: https://github.com/apps/ansible-zuul
setup_dvswitch: bump switch_version to 6.5.0 Reviewed-by: https://github.com/apps/ansible-zuul
tox: enable flake8 Reviewed-by: https://github.com/apps/ansible-zuul
galaxy: next version is 0.2.0 Reviewed-by: https://github.com/apps/ansible-zuul
Vmware module maintenance
Reviewed-by: Chris Holland
https://github.com/ChrisAHolland
tox: linters env only install flake8 Reviewed-by: https://github.com/apps/ansible-zuul
tox: venv env should install Ansible Reviewed-by: https://github.com/apps/ansible-zuul
Remove link to non-existing documentation Reviewed-by: https://github.com/apps/ansible-zuul
functional test for inventory Reviewed-by: https://github.com/apps/ansible-zuul
…oblems (ansible-collections#66) vmware_host_active_directory: Fail for unrecoverable AD problems Reviewed-by: https://github.com/apps/ansible-zuul
…tions#87) Change github url in galaxy.yml from git@ to https:// Reviewed-by: https://github.com/apps/ansible-zuul
This patch reverts changes done in ansible-collections#45 Signed-off-by: Abhijeet Kasurde <[email protected]>
vmware_vm_inventory: Test fix Reviewed-by: https://github.com/apps/ansible-zuul
…ons#102) vmware_host_service_manager: disable the test-suite Reviewed-by: https://github.com/apps/ansible-zuul
Update Hardware version to include 15 - 6.7U2 Reviewed-by: https://github.com/apps/ansible-zuul
…ections#234) Add requires_ansible version constraints to runtime.yml Reviewed-by: https://github.com/apps/ansible-zuul
dvswitch: collect the UUID Reviewed-by: https://github.com/apps/ansible-zuul
…ions#218) Added datastore managed object in vmware tag manager Reviewed-by: https://github.com/apps/ansible-zuul
update the URL of the vsphere SDK Reviewed-by: https://github.com/apps/ansible-zuul
…ansible-collections#11) VMware: Match state param in vmware_guest and vmware_guest_powerstate Reviewed-by: https://github.com/apps/ansible-zuul
Add new changelog configuration Reviewed-by: https://github.com/apps/ansible-zuul
) import changelog fragments from ansible/ansible Reviewed-by: https://github.com/apps/ansible-zuul
Update runtime.yml Reviewed-by: https://github.com/apps/ansible-zuul
vcsim/systemd: use the full path to vcsim Reviewed-by: https://github.com/apps/ansible-zuul
…me_settings (ansible-collections#225) VMware: Fix to be set default parameter for runtime_settings to runtime_settings Reviewed-by: https://github.com/apps/ansible-zuul
Add documentation Reviewed-by: https://github.com/apps/ansible-zuul
VMware: Fix the wronged module names in EXAMPLES block Reviewed-by: https://github.com/apps/ansible-zuul
linters: run antsibull-changelog lint Reviewed-by: https://github.com/apps/ansible-zuul
…ns#254) changelog: all fragments come with .yaml extension Reviewed-by: https://github.com/apps/ansible-zuul
…ons#253) Fail early with more info when all templates failed Reviewed-by: https://github.com/apps/ansible-zuul
vmware_content_deploy_ovf_template: fix import Reviewed-by: https://github.com/apps/ansible-zuul
import changelog for 1.0.0 release Reviewed-by: https://github.com/apps/ansible-zuul
sanity: add import boilerplate Reviewed-by: https://github.com/apps/ansible-zuul
sanity: address some pep8 error Reviewed-by: https://github.com/apps/ansible-zuul
…ter if you use VM name (ansible-collections#252) vmware_guest_snapshot_info: document that folder is a required parameter if you use VM name Reviewed-by: https://github.com/apps/ansible-zuul
vmware_tag_manager: add test for datastore Reviewed-by: https://github.com/apps/ansible-zuul
VMware: add new module vmware_host_iscsi Reviewed-by: https://github.com/apps/ansible-zuul
clean up the 1.0.0 changelog fragments Reviewed-by: https://github.com/apps/ansible-zuul
…tions#270) vmware_vm_inventory: Handle CustomFieldManger in ESXi Reviewed-by: https://github.com/apps/ansible-zuul
VMware: New module vmware_host_sriov Reviewed-by: https://github.com/apps/ansible-zuul
…ions#16) VMware: new module vmware_object_rename (Attempt II) Reviewed-by: https://github.com/apps/ansible-zuul
|
It looks like the rebase went rogue :-). Since your patch is rather short, you may find easier to just cherry-pick the import lines and start a new branch/PR. |
You're right @goneri, I'll close this PR and open another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix to the following error when the parameter vlanid is present on module invocation:
ISSUE TYPE
COMPONENT NAME
vmware_dvs_portgroup_find