Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware: Add vTPM information to facts data #1082

Merged
merged 2 commits into from
Oct 22, 2021
Merged

vmware: Add vTPM information to facts data #1082

merged 2 commits into from
Oct 22, 2021

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Oct 20, 2021 •
edited
Loading

SUMMARY

This PR will add vTPM information to default gather information for a virtual machine.
ref: #1075

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/vmware.py
changelogs/fragments/1082_vmware.yml

ADDITIONAL INFORMATION

tested on vCenter/ESXi 6.7 and 7.0

RETURN VALUE EXAMPLE

If vTPM is enabled

            "tpm_info": {
                "provider_id": "HyTrust KMS",
                "tpm_present": true
            },

If vTPM isn't enabled

            "tpm_info": {
                "provider_id": null,
                "tpm_present": false
            },

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils needs_triage Needs a first human triage before being processed. plugins plugin (any type) small_patch Hopefully easy to review labels Oct 20, 2021
mariolenz
mariolenz approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz added gate and removed needs_triage Needs a first human triage before being processed. labels Oct 22, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 023a5f7 into ansible-collections:main Oct 22, 2021
@sky-joker sky-joker mentioned this pull request Oct 26, 2021
Merged
@sky-joker
Copy link
Collaborator Author

Thanks @mariolenz !

@sky-joker sky-joker deleted the add_vtpm_info branch October 26, 2021 13:16
This was referenced Mar 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sky-joker @mariolenz @ansibullbot