vmware_dvswitch bug when adding contact info

[aleksandar-kinanov]

SUMMARY

There's a bug in how the contact info is added to vim.DistributedVirtualSwitch.ConfigInfo in the vmware_dvswitch module

ISSUE TYPE

• Bug Report

COMPONENT NAME

https://github.com/ansible-collections/community.vmware/blob/main/plugins/modules/vmware_dvswitch.py#L368

ANSIBLE VERSION

2.9.15

OS / ENVIRONMENT

SUSE 12.4

STEPS TO REPRODUCE

- name: Configure DVS
  vmware_dvswitch:
    hostname: 'some.vcenter'
    username: 'admin'
    password: 'pass'
    validate_certs: no
    datacenter: 'datacenter1'
    switch: 'switch1'
    contact: 
      name: admin
      description: some_description
    state: present
  delegate_to: localhost
  tags:
    - vcenter_network

EXPECTED RESULTS

Successfully created DVswitch with the required contact information

ACTUAL RESULTS

An exception is thrown by VmomiSupport.py

{
    "msg": "contact",
    "exception": "  File \"/tmp/ansible_vmware_dvswitch_payload_jv5hsa4g/ansible_vmware_dvswitch_payload.zip/ansible/modules/vmware_dvswitch.py\", line 332, in process_state\n  File \"/tmp/ansible_vmware_dvswitch_payload_jv5hsa4g/ansible_vmware_dvswitch_payload.zip/ansible/modules/vmware_dvswitch.py\", line 371, in create_dvswitch\n  File \"/var/lib/awx/venv/ansible_new/lib/python3.6/site-packages/pyVmomi/VmomiSupport.py\", line 665, in __setattr__\n    CheckField(self._GetPropertyInfo(name), val)\n  File \"/var/lib/awx/venv/ansible_new/lib/python3.6/site-packages/pyVmomi/VmomiSupport.py\", line 470, in GetPropertyInfo\n    raise AttributeError(name)\n",
    "invocation": {
        "module_args": {
            "hostname": "some.vcenter",
            "username": "admin",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "validate_certs": false,
            "datacenter": "datacenter1",
            "switch": "switch1",
            "version": "6.5.0",
            "uplink_quantity": 4,
            "discovery_operation": "both",
            "discovery_proto": "lldp",
            "mtu": 9000,
            "contact": {
                "name": "admin",
                "description": "some_description"
            },
            "state": "present",
            "datacenter_name": "false",
            "switch_name": "switch1",
            "switch_version": "6.5.0",
            "port": 443,
            "multicast_filtering_mode": "basic",
            "uplink_prefix": "Uplink ",
            "health_check": {
                "vlan_mtu": false,
                "teaming_failover": false,
                "vlan_mtu_interval": 0,
                "teaming_failover_interval": 0
            },
            "proxy_host": null,
            "proxy_port": null,
            "folder": null,
            "description": null
        }
    },
    "_ansible_no_log": false,
    "changed": false,
    "_ansible_delegated_vars": {}
}

Due to IP issues, I am not allowed to do a PR, but I can propose a fix:
Change this:
https://github.com/ansible-collections/community.vmware/blob/main/plugins/modules/vmware_dvswitch.py#L368
To this:

spec.configSpec.contact = self.create_contact_spec()

[ansibullbot]

Files identified in the description:

• plugins/modules/vmware_dvswitch.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Tomorrow9 @goneri @lparkes @pgbidkar @sky-joker @warthog9
click here for bot help

[Akasurde]

resolved_by_pr #614

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help