vmware_guest_video: gather_video_facts with powered on guest

[johansenha]

SUMMARY

gather_video_facts is only possible with powered off guest vm but should be possible with powered on machine as well and only changes to video settings should required powered off VM

ISSUE TYPE

• Bug Report

COMPONENT NAME

vmware_guest_video

ANSIBLE VERSION

2.9.13

OS / ENVIRONMENT

vSphere 7.0

STEPS TO REPRODUCE

ansible playbook

- hosts: localhost
  vars:
    selected_group: "test"
    vm_video_memory: "128"
  tasks:
    - name: Increase graphic memory
      include_role:
        name: vm
        tasks_from: increase_video_memory
      vars:
        machine: "{{ item }}"
      loop: "{{ groups[selected_group] }}"

task:

- name: "Check video settings of {{ item }}"
  vmware_guest_video:
    hostname: "{{ vcenter_hostname }}"
    username: "{{ vcenter_username }}"
    password: "{{ vcenter_password }}"
    datacenter: "{{ vcenter_datacenter }}"
    name: "{{ item }}"
    gather_video_facts: true
  delegate_to: localhost
  register: video_facts

ACTUAL RESULTS

fatal: [localhost]: FAILED! => {"changed": false, "msg": "VM state should be poweredoff to reconfigure video card settings."}

EXPECTED RESULTS

Usually I would expect that I can gather video facts as long as guest is running, or is there any other way to check video settings without using vmware_guest_video module?

[johansenha]

Possible solution might be changing vmware_guest_video.py

line 356 from:

if vm_power_state != 'poweredoff':

to:

if vm_facts == "" and vm_power_state != 'poweredoff':

[Akasurde]

@johansenha Thanks for reporting this issue. Could you please check if PR #411 resolves your issue?

Thanks.

needs_info

[johansenha]

@Akasurde Thanks for the quick fix. Patched my local file and response looks fine. LGTM