Finalize fields for "ppp profile" (#217)

A few defaults were missing for `ppp profile`. Mark the path as fully understood to enable its use in Ansible tasks. Signed-off-by: Michael Hanselmann <[email protected]>
ansible-collections · Sep 17, 2023 · 2bbaf26 · 2bbaf26
1 parent cf6c79e
commit 2bbaf26
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 13 deletions.
diff --git a/changelogs/fragments/217-ppp-profiles.yml b/changelogs/fragments/217-ppp-profiles.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - api_info, api_modify - finalize fields for the ``ppp profile`` path and enable it (https://github.com/ansible-collections/community.routeros/pull/217).
diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py
@@ -3339,36 +3339,37 @@ def join_path(path):
     ),
     ('ppp', 'profile'): APIData(
         unversioned=VersionedAPIData(
-            has_identifier=True,
+            fully_understood=True,
+            primary_keys=('name', ),
             fields={
-                'address-list': KeyInfo(),
+                'address-list': KeyInfo(default=''),
                 'bridge': KeyInfo(can_disable=True),
                 'bridge-horizon': KeyInfo(can_disable=True),
-                'bridge-learning': KeyInfo(),
+                'bridge-learning': KeyInfo(default='default'),
                 'bridge-path-cost': KeyInfo(can_disable=True),
                 'bridge-port-priority': KeyInfo(can_disable=True),
-                'change-tcp-mss': KeyInfo(),
+                'change-tcp-mss': KeyInfo(default=True),
                 'dns-server': KeyInfo(can_disable=True),
                 'idle-timeout': KeyInfo(can_disable=True),
                 'incoming-filter': KeyInfo(can_disable=True),
                 'insert-queue-before': KeyInfo(can_disable=True),
                 'interface-list': KeyInfo(can_disable=True),
                 'local-address': KeyInfo(can_disable=True),
-                'name': KeyInfo(),
-                'on-down': KeyInfo(),
-                'on-up': KeyInfo(),
-                'only-one': KeyInfo(),
+                'name': KeyInfo(required=True),
+                'on-down': KeyInfo(default=''),
+                'on-up': KeyInfo(default=''),
+                'only-one': KeyInfo(default='default'),
                 'outgoing-filter': KeyInfo(can_disable=True),
                 'parent-queue': KeyInfo(can_disable=True),
                 'queue-type': KeyInfo(can_disable=True),
                 'rate-limit': KeyInfo(can_disable=True),
                 'remote-address': KeyInfo(can_disable=True),
                 'session-timeout': KeyInfo(can_disable=True),
-                'use-compression': KeyInfo(),
-                'use-encryption': KeyInfo(),
-                'use-ipv6': KeyInfo(),
-                'use-mpls': KeyInfo(),
-                'use-upnp': KeyInfo(),
+                'use-compression': KeyInfo(default='default'),
+                'use-encryption': KeyInfo(default='default'),
+                'use-ipv6': KeyInfo(default=True),
+                'use-mpls': KeyInfo(default='default'),
+                'use-upnp': KeyInfo(default='default'),
                 'wins-server': KeyInfo(can_disable=True),
             },
         ),

diff --git a/plugins/modules/api_info.py b/plugins/modules/api_info.py
@@ -148,6 +148,7 @@
         - mpls ldp
         - port firmware
         - ppp aaa
+        - ppp profile
         - queue interface
         - queue tree
         - radius incoming

diff --git a/plugins/modules/api_modify.py b/plugins/modules/api_modify.py
@@ -157,6 +157,7 @@
         - mpls ldp
         - port firmware
         - ppp aaa
+        - ppp profile
         - queue interface
         - queue tree
         - radius incoming