Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql_pg_hba: fix file parsing #458

Closed

Conversation

betanummeric
Copy link
Member

@betanummeric betanummeric commented Apr 26, 2023

fixes #420, replaces #423

This PR is a bugfix for the postgresql_pg_hba module: Lines of the pg_hba.conf can contain quoted fields which can contain # or an escaped quote (\"). This was not parsed correctly before.

@Andersson007
Copy link
Collaborator

@betanummeric hi, if the PR is still relevant or can be closed (as well as that initial one) ? If it is but you have no time now, we can keep it open, NP.

@betanummeric
Copy link
Member Author

Hi @Andersson007 , I forgot about this PR and I don't really have time to proceed now, sorry. I guess the issue about special chars in the pg_hba.conf remains valid (although I didn't keep track of changes).
As written in my last comment, this PR would replace #423, but I'm inactive here so it might as well be solved in another PR.

@Andersson007
Copy link
Collaborator

@betanummeric hi, sure, no problem, let's close the PR
I'll put a link in the issue that people can use it as a basis when fixing the issue, thanks! If you once have time again to finish it, just open it:) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldapbindpasswd in options which includes '#' creates faulty pg_hba lines
3 participants