-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare un-flatmapping #469
Prepare un-flatmapping #469
Conversation
29cce54
to
bcf69bf
Compare
Currently contains #470. |
bcf69bf
to
f5a7970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titanic work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #472 🤖 @patchback |
* Add prefix to fixtures directory to avoid name-clashes when removing flatmapping. * Make sure string replacement works when automatically un-flatmapping. * Match filenames inside directories. (cherry picked from commit a1f1593)
@Andersson007 @russoz thanks a lot for reviewing this! |
* Add prefix to fixtures directory to avoid name-clashes when removing flatmapping. * Make sure string replacement works when automatically un-flatmapping. * Match filenames inside directories. (cherry picked from commit a1f1593) Co-authored-by: Felix Fontein <[email protected]>
SUMMARY
Prepares un-flatmapping. When collapsing the tests/unit/plugins/modules directory tree, there are some clashes because there are different
fixtures
directories in the tree structure. This PR renames thesefixtures
directories by prepending them with the module group names.Also removes some string wrapping so that automatic replacements work.
With these changes, https://gist.github.com/felixfontein/3123dcdf446c9e140949a0589cceb99d can remove flatmapping and at least the Python 3.10 unit tests still pass :)
Ref: ansible-community/community-topics#147
ISSUE TYPE
COMPONENT NAME
unit tests