mysql_role: fix and simplify role member detection #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 78.23% 77.99% -0.24%
==========================================
Files 27 27
Lines 2270 2259 -11
Branches 551 546 -5
==========================================
- Hits 1776 1762 -14
- Misses 335 339 +4
+ Partials 159 158 -1
Continue to review full report at Codecov.
|
|
@betanummeric thanks for the fix! Could you please add a changelog fragment |
There was a problem hiding this comment.
LGTM @betanummeric thanks! Let's make the changelog entries consistent so could you please change it and after that i'll merge the PR.
Co-authored-by: Andrew Klychkov <[email protected]>
|
@betanummeric thanks for the contribution! |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #371 🤖 @patchback |
* mysql_role: fix and simplify role membership detection * add changelog fragment * Update changelogs/fragments/368-mysql_role-fix-member-detection.yml Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Felix Hamme <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 07a7286)
* mysql_role: fix and simplify role membership detection * add changelog fragment * Update changelogs/fragments/368-mysql_role-fix-member-detection.yml Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Felix Hamme <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 07a7286) Co-authored-by: betanummeric <[email protected]>
bugfix for mysql_role
fixes #366 ("detaching too few members")
Instead of parsing the
show grantsstatement output for each user, query the built-in tables to find out who is member of a role.MySQL: mysql.role_edges
MariaDB: mysql.roles_mapping