mysql_user: reinitialize the privs list in privileges_unpack()

[parseword]

SUMMARY

In some scenarios, privileges_unpack() called privs.append() inside a loop without first emptying or reinitializing the privs list from the prior iteration. This could result in an invalid GRANT statement, which incorrectly included privileges from a previously-built GRANT statement.

Reinitialize privs on each pass of the loop to prevent this from occurring.

Fixes #136

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

mysql_user

[codecov]

Codecov Report

Merging #137 (929240e) into main (ba791bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files          20       20           
  Lines        1770     1770           
  Branches      436      436           
=======================================
  Hits         1356     1356           
  Misses        268      268           
  Partials      146      146           

Impacted Files	Coverage Δ
plugins/modules/mysql_user.py	81.15% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba791bf...929240e. Read the comment docs.

[parseword]

Ready for review

[Andersson007]

@parseword thanks for the PR!
We have CI tests for the module stored in tests/integration/targets/test_mysql_user/tasks/. Could you please cover the case there (just add the task(s) to somewhere which failed before the fix and now works)

[parseword]

That's wading into uncharted territory for me, but I'll give it a shot tomorrow. I think I can put something together by cribbing from the test_priv_append.yml task.

[Andersson007]

ok, if any questions, feel free to ask

[Jorge-Rodriguez]

@parseword if you feel more confident covering this bug fix with a unit test instead, we have those stored in tests/unit/plugins/modules

[Andersson007]

@parseword do we have any time estimates? I'm asking because We're gonna release 2.0.0 next week.
We could wait until you finish this.
If you need more time, no problem, no rush, we could release without this fix and include it in 2.0.1 shortly after. What do you think?

[Jorge-Rodriguez]

@parseword Can you add tests for this?

[Jorge-Rodriguez]

@parseword The code patched in this PR has been moved to /plugins/module_utils/user.py

[Jorge-Rodriguez]

I reviewed this more closely and after we removed the static check for valid privileges this issue has disappeared as we never read the privs list in the privileges_unpack function. My comment on issue #136 still applies.