Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_remote_temp_dir: Set ignore_errors true on delete tempdir handler task #594

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

rhysmeister
Copy link
Collaborator

SUMMARY

Occasional errors happen on the "delete temporary directory". It's safe to ignore these so let's do so.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

setup_remote_temp_dir

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (a5ed810) 73.19% compared to head (55b5ff7) 73.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   73.19%   73.08%   -0.11%     
==========================================
  Files           6        6              
  Lines         929      929              
  Branches      143      143              
==========================================
- Hits          680      679       -1     
  Misses        213      213              
- Partials       36       37       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhysmeister rhysmeister merged commit 1d43010 into master Sep 2, 2023
251 of 252 checks passed
@rhysmeister rhysmeister deleted the bugfix/ignore-temp-dir-delete-err branch September 2, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant