Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of testing and README updates #82

Merged
merged 2 commits into from
May 21, 2021

Conversation

briantist
Copy link
Collaborator

@briantist briantist commented May 20, 2021

SUMMARY

Somewhat related: #81

With two releases of hvac broken on Py2 (inadvertently), I've started thinking it's time to drop Python2 support, hence the linked issue.

This PR started as trying to fix the tests to ensure they don't use the affected versions of hvac, some other changes went in.

Testing

  • constraints.txt and requirements.txt updated to stop at hvac 0.10.11 in Python 2. As of this writing, 0.10.14 hasn't been released yet but it's expected it will restore Py2 compatibility. At that time I may change the constraints to exclude the two affected, and let it bring in newer ones, we'll see.
  • The custom playbook for installing requirements in integration tests was not using the constraints file included in the collection. That has been changed.
  • The requirements playbook's lines for choosing very old versions of hvac to work with old versions of OSes that are no longer tested against, have been removed.

CI

  • Reduced the number of Vault versions being tested against from 3 down to 2, and updated which versions to keep in line with newer Vault releases. The strain on CI was getting higher and it seems GitHub has reduced the available concurrency so CI runs were taking ever longer, especially considering the previous addition of Ansible 2.11 to the matrix.
  • Added Python 3.10 testing, only in devel and only in the latest Vault version for now, in accordance with: Changes impacting Collection Contributors and maintainers overview#45 (comment)

Documentation

README updated to:

  • describe hvac requirements, add Py2 notice and link to issue
  • better describe supported python versions
  • better describe supported Ansible versions
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION

@briantist briantist added documentation Improvements or additions to documentation tests Adds or modifies tests ci Specifically related to the CI on this repo labels May 20, 2021
@briantist briantist self-assigned this May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #82 (e792740) into main (08f5270) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files          16       16           
  Lines         783      783           
  Branches       78       78           
=======================================
  Hits          649      649           
  Misses        120      120           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f5270...e792740. Read the comment docs.

@briantist briantist merged commit b6dfd80 into ansible-collections:main May 21, 2021
@briantist briantist mentioned this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Specifically related to the CI on this repo documentation Improvements or additions to documentation tests Adds or modifies tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant