Vault 1.18 has a new exception response string

[mathijswesterhof]

SUMMARY

Vault 1.18 has updated it's exception string therefor the integration tests for hashi_vault are now failing.

This pull request fixes the integration test failure.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• auth_cert

ADDITIONAL INFORMATION

hashicorp/vault@v1.17.6...v1.18.0 has the following change in file builtin/credential/cert/path_login.go

+ const certAuthFailMsg = "failed to match all constraints for this login certificate"
...
- return nil, logical.ErrorResponse(fmt.Sprintf("invalid certificate or no client certificate supplied; additionally got errors during verification: %v", retErr)), nil
+ return nil, logical.ErrorResponse(fmt.Sprintf("%s; additionally got errors during verification: %v", certAuthFailMsg, retErr)), nil

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (6f1303a) to head (ba7f428).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         109      109           
  Lines        6203     6203           
  Branches     1184     1184           
=======================================
  Hits         6154     6154           
  Misses         39       39           
  Partials       10       10           

Flag	Coverage Δ
env_docker-default	99.21% <ø> (ø)
integration	81.11% <ø> (ø)
sanity	41.12% <ø> (ø)
target_auth_approle	89.47% <ø> (ø)
target_auth_aws_iam	50.00% <ø> (ø)
target_auth_azure	53.84% <ø> (ø)
target_auth_cert	86.36% <ø> (ø)
target_auth_jwt	91.30% <ø> (ø)
target_auth_ldap	89.47% <ø> (ø)
target_auth_none	100.00% <ø> (ø)
target_auth_token	71.42% <ø> (ø)
target_auth_userpass	85.71% <ø> (ø)
target_connection_options	74.76% <ø> (ø)
target_controller	83.41% <ø> (ø)
target_filter_vault_login_token	77.77% <ø> (ø)
target_import	41.12% <ø> (ø)
target_lookup_hashi_vault	81.33% <ø> (ø)
target_lookup_vault_ansible_settings	56.00% <ø> (ø)
target_lookup_vault_kv1_get	91.30% <ø> (ø)
target_lookup_vault_kv2_get	91.11% <ø> (ø)
target_lookup_vault_list	90.00% <ø> (ø)
target_lookup_vault_login	88.57% <ø> (ø)
target_lookup_vault_read	90.00% <ø> (ø)
target_lookup_vault_token_create	79.24% <ø> (ø)
target_lookup_vault_write	56.95% <ø> (ø)
target_module_utils	96.74% <ø> (ø)
target_module_vault_database_connection_configure	56.39% <ø> (ø)
target_module_vault_database_connection_delete	56.21% <ø> (ø)
target_module_vault_database_connection_read	56.14% <ø> (ø)
target_module_vault_database_connection_reset	56.21% <ø> (ø)
target_module_vault_database_connections_list	55.63% <ø> (ø)
target_module_vault_database_role_create	55.63% <ø> (ø)
target_module_vault_database_role_delete	56.21% <ø> (ø)
target_module_vault_database_role_read	56.14% <ø> (ø)
target_module_vault_database_roles_list	55.63% <ø> (ø)
target_module_vault_database_rotate_root_creds	56.02% <ø> (ø)
target_module_vault_database_static_role_create	56.39% <ø> (ø)
target_module_vault_database_static_role_get_creds	56.14% <ø> (ø)
target_module_vault_database_static_role_read	56.14% <ø> (ø)
target_module_vault_database_static_role_rotate_creds	56.02% <ø> (ø)
target_module_vault_database_static_roles_list	55.63% <ø> (?)
target_module_vault_kv1_get	87.50% <ø> (ø)
target_module_vault_kv2_delete	56.85% <ø> (ø)
target_module_vault_kv2_get	87.23% <ø> (ø)
target_module_vault_kv2_write	57.26% <ø> (ø)
target_module_vault_list	85.71% <ø> (ø)
target_module_vault_login	83.72% <ø> (ø)
target_module_vault_pki_generate_certificate	78.72% <ø> (ø)
target_module_vault_read	?
target_module_vault_token_create	91.66% <ø> (ø)
target_module_vault_write	56.02% <ø> (ø)
target_modules	88.55% <ø> (ø)
units	95.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[briantist]

@mathijswesterhof thank you for this fix!