-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashi_vault
lookup - raise exception on duplicate term string options
#375
Merged
briantist
merged 2 commits into
ansible-collections:main
from
briantist:hashi_vault_lookup/kev-term-dups
May 11, 2023
Merged
hashi_vault
lookup - raise exception on duplicate term string options
#375
briantist
merged 2 commits into
ansible-collections:main
from
briantist:hashi_vault_lookup/kev-term-dups
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
bug
Something isn't working
breaking-change
Describes current or future breaking changes
labels
May 10, 2023
briantist
changed the title
Hashi vault lookup/kev term dups
May 10, 2023
hashi_vault
lookup - raise exception on duplicate term string options
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 98.86% 98.86% -0.01%
==========================================
Files 82 82
Lines 4236 4234 -2
Branches 267 267
==========================================
- Hits 4188 4186 -2
Misses 39 39
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
felixfontein
approved these changes
May 10, 2023
@felixfontein thanks a lot for reviewing! |
fh-carlosp
pushed a commit
to flatironhealth/community.hashi_vault
that referenced
this pull request
May 15, 2023
…ns (ansible-collections#375) * raise exception on duplicate term string option * add changelog fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #356
See also:
hashi_vault
lookup plugin behavior on option duplication #349ISSUE TYPE