Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashi_vault lookup - raise exception on duplicate term string options #375

Merged

Conversation

briantist
Copy link
Collaborator

@briantist briantist commented May 10, 2023

@briantist briantist added bug Something isn't working breaking-change Describes current or future breaking changes labels May 10, 2023
@briantist briantist added this to the v5.0.0 milestone May 10, 2023
@briantist briantist self-assigned this May 10, 2023
@briantist briantist changed the title Hashi vault lookup/kev term dups hashi_vault lookup - raise exception on duplicate term string options May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #375 (165897b) into main (eed0111) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 165897b differs from pull request most recent head 56cbc6b. Consider uploading reports for the commit 56cbc6b to get more accurate results

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   98.86%   98.86%   -0.01%     
==========================================
  Files          82       82              
  Lines        4236     4234       -2     
  Branches      267      267              
==========================================
- Hits         4188     4186       -2     
  Misses         39       39              
  Partials        9        9              
Flag Coverage Δ
env_docker-default 98.86% <100.00%> (-0.01%) ⬇️
integration 81.31% <100.00%> (+0.24%) ⬆️
sanity 39.49% <50.00%> (+0.02%) ⬆️
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.93% <100.00%> (-0.02%) ⬇️
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.49% <50.00%> (+0.02%) ⬆️
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 56.07% <50.00%> (+0.06%) ⬆️
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.11% <ø> (ø)
target_lookup_vault_list 90.00% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.14% <50.00%> (+0.08%) ⬆️
target_module_utils 97.48% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 56.93% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_kv2_write 57.32% <ø> (ø)
target_module_vault_list 85.71% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.25% <ø> (ø)
target_modules 82.09% <ø> (ø)
units 95.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/plugin_utils/_hashi_vault_lookup_base.py 100.00% <100.00%> (ø)
.../plugin_utils/base/test_hashi_vault_lookup_base.py 100.00% <100.00%> (ø)

@briantist
Copy link
Collaborator Author

@felixfontein thanks a lot for reviewing!

@briantist briantist merged commit 8031972 into ansible-collections:main May 11, 2023
@briantist briantist deleted the hashi_vault_lookup/kev-term-dups branch May 11, 2023 04:20
fh-carlosp pushed a commit to flatironhealth/community.hashi_vault that referenced this pull request May 15, 2023
…ns (ansible-collections#375)

* raise exception on duplicate term string option

* add changelog fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Describes current or future breaking changes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The hashi_vault lookup will raise an error on duplicate term string options in v5.0.0
2 participants