-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated environment variables for 2.0.0 #173
remove deprecated environment variables for 2.0.0 #173
Conversation
ac20654
to
d414150
Compare
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 40 40
Lines 1587 1587
Branches 123 123
=======================================
Hits 1455 1455
Misses 119 119
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
##Docs Build 📝 Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
recheck |
@briantist @felixfontein |
@briantist Correct, the concern is that sensitive variables are exposed. Thus we were hoping to utilize custom credentials which do now allow for ansible to be prepended. We can stick with modifying the docfragments if it creates too much of a problem. |
I'm not sure why AWX/Tower doesn't like these, but prefixing with |
AWX credentials can inject its values as either environment variables or as Ansible vars. By injecting as Ansible vars, you will avoid this issue, because the The issue I linked is where others brought up the concerns, and using Ansible vars completely solves the issue, there should be no reason to modify any docs fragments. |
I agree with you and have tried to argue the same. Here's a partial answer: ansible/awx#10275 (comment) I guess the issue is that you could use those creds to widely control Ansible behavior in ways beyond plugin configuration? But yeah, it does mean that you cannot use env vars in that way to assign options, so plugins should need to be specific about accepting |
This is the check: Appreciate the quick responses! |
Yes, again that is the check for environment variables, if you choose to inject as Ansible vars instead, there is so such check. Please read the linked thread. |
@briantist @felixfontein |
SUMMARY
Removes deprecated env vars for the 2.0.0 release:
ISSUE TYPE
COMPONENT NAME
auth.py
ADDITIONAL INFORMATION
This completes the breaking changes that came from #10