-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common options - change ini section, deprecate old, separate plugin doc fragments #144
common options - change ini section, deprecate old, separate plugin doc fragments #144
Conversation
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.01%
==========================================
Files 34 34
Lines 1346 1348 +2
Branches 102 102
==========================================
+ Hits 1201 1203 +2
Misses 135 135
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the implementation/larger implications of this change, but I did find one very small nit in the docs.
Co-authored-by: Alicia Cozine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no apparent issues with this PR, but I did not test the code since I am not intimately familiar with the Hashi Vault.
SUMMARY
The currently used INI section,
lookup_hashi_vault
, is specific to thehashi_vault
lookup, but the options have all been moved to doc fragments with the intention for them to be shared collection-wide, in both modules and plugins.To those ends, this PR:
hashi_vault_collection
that replaceslookup_hashi_vault
lookup_hashi_vault
INI section in version 3.0.0lookup_hashi_vault
INI section is only valid within thehashi_vault
lookup, and won't be inherited by new content; unfortunately to do this, I had to duplicate all the options within that plugin, including the shared INI sections. So that's going to be crappy for maintenance for a while.[lookup_hashi_vault]
and[hashi_vault_collection]
sections, the latter wins.hashi_vault
lookup and the test lookups to use the new doc fragment sectionsISSUE TYPE
COMPONENT NAME
plugins/doc_fragments
ADDITIONAL INFORMATION
N/A