(internals) make _utils internal to the collection (#63)

* Add supported python versions and internal use disclaimer to module_util

* Mark  module_util as private and update references

* Rename test file

* fix typo

* Add internal use disclaimer to plugin_util

* Rename plugin_util with underscore, update references

plugins/lookup/__init__.py

@@ -9,7 +9,7 @@
 from ansible.plugins.lookup import LookupBase
 from ansible.utils.display import Display
 
-from ansible_collections.community.hashi_vault.plugins.plugin_utils.hashi_vault_plugin import HashiVaultPlugin
+from ansible_collections.community.hashi_vault.plugins.plugin_utils._hashi_vault_plugin import HashiVaultPlugin
 
 display = Display()
 

plugins/lookup/hashi_vault.py

@@ -337,7 +337,7 @@
 from ansible.utils.display import Display
 
 from ansible_collections.community.hashi_vault.plugins.lookup.__init__ import HashiVaultLookupBase
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import HashiVaultHelper
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import HashiVaultHelper
 
 display = Display()
 

plugins/module_utils/hashi_vault_common.py → plugins/module_utils/_hashi_vault_common.py

@@ -2,6 +2,14 @@
 # Copyright (c) 2021 Brian Scholer (@briantist)
 # Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
 
+'''Python versions supported: all controller-side versions, all remote-side versions except 2.6'''
+
+# FOR INTERNAL COLLECTION USE ONLY
+# The interfaces in this file are meant for use within the community.hashi_vault collection
+# and may not remain stable to outside uses. Changes may be made in ANY release, even a bugfix release.
+# See also: https://github.com/ansible/community/issues/539#issuecomment-780839686
+# Please open an issue if you have questions about this.
+
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 

plugins/plugin_utils/hashi_vault_plugin.py → plugins/plugin_utils/_hashi_vault_plugin.py

@@ -2,6 +2,11 @@
 # Copyright (c) 2021 Brian Scholer (@briantist)
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
+# FOR INTERNAL COLLECTION USE ONLY
+# The interfaces in this file are meant for use within the community.hashi_vault collection
+# and may not remain stable to outside uses. Changes may be made in ANY release, even a bugfix release.
+# See also: https://github.com/ansible/community/issues/539#issuecomment-780839686
+# Please open an issue if you have questions about this.
 
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -10,7 +15,7 @@
 from ansible import constants as C
 from ansible.utils.display import Display
 
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import (
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import (
     HashiVaultHelper,
     HashiVaultOptionAdapter,
     HashiVaultConnectionOptions,

tests/unit/plugins/base/test_hashi_vault_lookup_base.py

@@ -10,7 +10,7 @@
 from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 
-from ansible_collections.community.hashi_vault.plugins.plugin_utils.hashi_vault_plugin import HashiVaultPlugin
+from ansible_collections.community.hashi_vault.plugins.plugin_utils._hashi_vault_plugin import HashiVaultPlugin
 from ansible_collections.community.hashi_vault.plugins.lookup.__init__ import HashiVaultLookupBase
 
 

tests/unit/plugins/base/test_hashi_vault_plugin.py

@@ -9,8 +9,8 @@
 
 from ansible.plugins import AnsiblePlugin
 
-from ansible_collections.community.hashi_vault.plugins.plugin_utils.hashi_vault_plugin import HashiVaultPlugin
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import HashiVaultOptionAdapter
+from ansible_collections.community.hashi_vault.plugins.plugin_utils._hashi_vault_plugin import HashiVaultPlugin
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import HashiVaultOptionAdapter
 
 
 @pytest.fixture

tests/unit/plugins/module_utils/test_hashi_vault_connection_options.py

@@ -10,7 +10,7 @@
 
 from ansible_collections.community.hashi_vault.tests.unit.compat import mock
 
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import (
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import (
     HashiVaultOptionGroupBase,
     HashiVaultConnectionOptions,
     HashiVaultOptionAdapter,

tests/unit/plugins/module_utils/test_hashi_vault_common.py → tests/unit/plugins/module_utils/test_hashi_vault_helper.py

@@ -10,7 +10,7 @@
 import pytest
 
 from ansible_collections.community.hashi_vault.tests.unit.compat import mock
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import HashiVaultHelper
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import HashiVaultHelper
 
 
 @pytest.fixture

tests/unit/plugins/module_utils/test_hashi_vault_option_adapter.py

@@ -9,7 +9,7 @@
 
 from ansible.plugins import AnsiblePlugin
 
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import HashiVaultOptionAdapter
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import HashiVaultOptionAdapter
 
 
 SAMPLE_DICT = {

tests/unit/plugins/module_utils/test_hashi_vault_option_group_base.py

@@ -10,7 +10,7 @@
 
 from ansible_collections.community.hashi_vault.tests.unit.compat import mock
 
-from ansible_collections.community.hashi_vault.plugins.module_utils.hashi_vault_common import (
+from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import (
     HashiVaultOptionGroupBase,
     HashiVaultOptionAdapter,
 )