Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nagios: force an active service check for all services of a particular host or for the host itself #998

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

trumbaut
Copy link
Contributor

SUMMARY

Added functionality to force an active service check for all services of a particular host or for the host itself.

Note that I've renamed the service_check command to forced_check since we now are able to check both a particular service, all services of a particular host and the host itself. This aligns to the downtime command.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nagios.py

ADDITIONAL INFORMATION

Force an active service check for all services of a particular host or for the host itself
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 community_review feature This issue/PR relates to a feature request module module monitoring needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 29, 2020
@felixfontein felixfontein changed the title Force an active service check for all services of a particular host or for the host itself nagios: force an active service check for all services of a particular host or for the host itself Sep 29, 2020
@felixfontein
Copy link
Collaborator

If service_check should be renamed, it must be done today, since we release community.general 1.2.0 tomorrow. Once its released, a rename would be a breaking change.

You need a changelog fragment.

@tgoetheyn
Copy link
Contributor

A rename is fine for me, as this way of doing it aligns the function more with the existing downtime command

Copy link
Contributor

@tgoetheyn tgoetheyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my development environment.
Everything works fine

@tgoetheyn
Copy link
Contributor

@felixfontein the code itself is ok.

If the changelog fragment is compliant with the guidelines, then it can be merged

@felixfontein felixfontein merged commit 9b24b7a into ansible-collections:main Sep 29, 2020
@felixfontein
Copy link
Collaborator

@trumbaut thanks for implementing this!
@tgoetheyn thanks for testing and reviewing!

patchback bot pushed a commit that referenced this pull request Sep 29, 2020
…r host or for the host itself (#998)

* Update nagios.py

Force an active service check for all services of a particular host or for the host itself

* Create 998-nagios-added_forced_check_for_all_services_or_host.yml

Added fragment

(cherry picked from commit 9b24b7a)
felixfontein pushed a commit that referenced this pull request Sep 29, 2020
…r host or for the host itself (#998) (#1003)

* Update nagios.py

Force an active service check for all services of a particular host or for the host itself

* Create 998-nagios-added_forced_check_for_all_services_or_host.yml

Added fragment

(cherry picked from commit 9b24b7a)

Co-authored-by: trumbaut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request module module monitoring new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants