Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action plugins: use f-strings #9318

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 23, 2024

SUMMARY

Use f-strings instead of string interpolations or string format().

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/action/iptables_state.py
plugins/action/shutdown.py

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added action action plugin plugins plugin (any type) labels Dec 23, 2024
@felixfontein felixfontein added backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 23, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/action/shutdown.py Show resolved Hide resolved
@felixfontein felixfontein merged commit 79bef1a into ansible-collections:main Dec 23, 2024
129 checks passed
Copy link

patchback bot commented Dec 23, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/79bef1a14c09f652f0d2833cd0eea3251309c373/pr-9318

Backported as #9333

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 23, 2024
@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Dec 23, 2024
* action plugins: use f-strings

* add changelog frag

* adjustment from review

(cherry picked from commit 79bef1a)
@russoz russoz deleted the fstr-actionplugins branch December 23, 2024 10:40
felixfontein pushed a commit that referenced this pull request Dec 23, 2024
…#9333)

action plugins: use f-strings (#9318)

* action plugins: use f-strings

* add changelog frag

* adjustment from review

(cherry picked from commit 79bef1a)

Co-authored-by: Alexei Znamensky <[email protected]>
erichoog pushed a commit to erichoog/community.general that referenced this pull request Dec 23, 2024
* action plugins: use f-strings

* add changelog frag

* adjustment from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action action plugin backport-10 Automatically create a backport for the stable-10 branch plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants