-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action plugins: use f-strings #9318
Merged
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz-ansible:fstr-actionplugins
Dec 23, 2024
Merged
action plugins: use f-strings #9318
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz-ansible:fstr-actionplugins
Dec 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
backport-10
Automatically create a backport for the stable-10 branch
check-before-release
PR will be looked at again shortly before release and merged if possible.
labels
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
felixfontein
approved these changes
Dec 23, 2024
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9333 🤖 @patchback |
felixfontein
removed
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
Dec 23, 2024
@russoz thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* action plugins: use f-strings * add changelog frag * adjustment from review (cherry picked from commit 79bef1a)
felixfontein
pushed a commit
that referenced
this pull request
Dec 23, 2024
…#9333) action plugins: use f-strings (#9318) * action plugins: use f-strings * add changelog frag * adjustment from review (cherry picked from commit 79bef1a) Co-authored-by: Alexei Znamensky <[email protected]>
erichoog
pushed a commit
to erichoog/community.general
that referenced
this pull request
Dec 23, 2024
* action plugins: use f-strings * add changelog frag * adjustment from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action
action plugin
backport-10
Automatically create a backport for the stable-10 branch
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use f-strings instead of string interpolations or string format().
ISSUE TYPE
COMPONENT NAME
plugins/action/iptables_state.py
plugins/action/shutdown.py