Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect key lookup #9223

Merged

Conversation

IamLunchbox
Copy link
Contributor

@IamLunchbox IamLunchbox commented Dec 5, 2024

SUMMARY

Fixes a key lookup bug in modules/proxmox_backup. May be extended with further fixes, when encountered in upcoming usage.

Currently, if the permission tree for vms does not include "/" and at the same time does contain "/vms", the module fails.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_backup

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug module module plugins plugin (any type) small_patch Hopefully easy to review labels Dec 5, 2024
@IamLunchbox IamLunchbox marked this pull request as ready for review December 5, 2024 13:39
@ansibullbot ansibullbot removed WIP Work in progress small_patch Hopefully easy to review labels Dec 5, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 5, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will merge in a few days if nobody objects.

Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 9, 2024
@felixfontein felixfontein merged commit 6f87bf2 into ansible-collections:main Dec 9, 2024
129 checks passed
Copy link

patchback bot commented Dec 9, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/6f87bf2bade07f5ef47f15700b7d0ae89c78145a/pr-9223

Backported as #9232

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@IamLunchbox thanks for fixing this!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Dec 9, 2024
* Fix incorrect key lookup

* Create changelog fragment

(cherry picked from commit 6f87bf2)
felixfontein pushed a commit that referenced this pull request Dec 9, 2024
Fix incorrect key lookup (#9223)

* Fix incorrect key lookup

* Create changelog fragment

(cherry picked from commit 6f87bf2)

Co-authored-by: IamLunchbox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants