Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfish_utils: remove undocumented default applytime #9114

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

sinuscosinustan
Copy link
Contributor

SUMMARY

The @Redfish.OperationApplyTime parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils

ADDITIONAL INFORMATION

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 11, 2024
@mraineri
Copy link
Contributor

Looks good to me, thanks!

shipit

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Nov 11, 2024
@felixfontein felixfontein merged commit bafb8ac into ansible-collections:main Nov 11, 2024
129 checks passed
Copy link

patchback bot commented Nov 11, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/bafb8aca292dfb365a6386cc52e4de40f8e6bfc6/pr-9114

Backported as #9119

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 11, 2024
patchback bot pushed a commit that referenced this pull request Nov 11, 2024
* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <[email protected]>

---------

Signed-off-by: Tan Siewert <[email protected]>
(cherry picked from commit bafb8ac)
Copy link

patchback bot commented Nov 11, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/bafb8aca292dfb365a6386cc52e4de40f8e6bfc6/pr-9114

Backported as #9120

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@tomsiewert thanks for your contribution!
@mraineri thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Nov 11, 2024
* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <[email protected]>

---------

Signed-off-by: Tan Siewert <[email protected]>
(cherry picked from commit bafb8ac)
@sinuscosinustan sinuscosinustan deleted the ts-redfish branch November 11, 2024 19:05
felixfontein pushed a commit that referenced this pull request Nov 11, 2024
…ented default applytime (#9120)

redfish_utils: remove undocumented default applytime (#9114)

* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <[email protected]>

---------

Signed-off-by: Tan Siewert <[email protected]>
(cherry picked from commit bafb8ac)

Co-authored-by: Tan Siewert <[email protected]>
felixfontein pushed a commit that referenced this pull request Nov 11, 2024
…nted default applytime (#9119)

redfish_utils: remove undocumented default applytime (#9114)

* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <[email protected]>

---------

Signed-off-by: Tan Siewert <[email protected]>
(cherry picked from commit bafb8ac)

Co-authored-by: Tan Siewert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants