Redfish: Added handling for trailing slashes in URIs when extracting member identifiers #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…member identifiers Signed-off-by: Mike Raineri <[email protected]>
ansibullbot
added
bug
felixfontein
added
check-before-release
Co-authored-by: Alexei Znamensky <[email protected]>
ansibullbot
added
the
needs_revision
ansibullbot
removed
the
needs_revision
Co-authored-by: Felix Fontein <[email protected]>
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #9078 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…member identifiers (#9057) Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit c71f662)
felixfontein
pushed a commit
that referenced
this pull request
Oct 29, 2024
…ailing slashes in URIs when extracting member identifiers (#9078) Redfish: Added handling for trailing slashes in URIs when extracting member identifiers (#9057) Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit c71f662) Co-authored-by: Mike Raineri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some implementations have trailing slashes in their URIs. While most of this module's code does not rely on exact URIs, some places will take the last URI segment using the
splitfunction when determining identifiers for collection members. In these cases, it'll be an empty string. Specifically for volume management, thesplitfunction was assuming trailing slashes were always present.The change here always removes trailing slashes before trying to extract member identifiers.
Fix #9047
ISSUE TYPE
COMPONENT NAME
redfish_utils