Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipx/pipx_info: multiple fixes #9044

Merged
merged 18 commits into from
Nov 2, 2024
Merged

pipx/pipx_info: multiple fixes #9044

merged 18 commits into from
Nov 2, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Oct 19, 2024 •
edited
Loading

SUMMARY

The integration tests were flawed, not really testing the latest features, specially global.

Fixes #9009

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Refactoring Pull Request
  • Test Pull Request
COMPONENT NAME

pipx
pipx_info

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module module_utils module_utils plugins plugin (any type) tests tests labels Oct 19, 2024
@felixfontein felixfontein added backport-9 Automatically create a backport for the stable-9 branch and removed backport-9 Automatically create a backport for the stable-9 branch labels Oct 20, 2024
@russoz russoz changed the title [WIP] pipx/pipx_info: multiple fixes pipx/pipx_info: multiple fixes Oct 24, 2024
@ansibullbot ansibullbot removed the WIP Work in progress label Oct 24, 2024
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 24, 2024
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 24, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. and removed check-before-release PR will be looked at again shortly before release and merged if possible. labels Oct 28, 2024
@felixfontein felixfontein merged commit 2429e22 into ansible-collections:main Nov 2, 2024
126 checks passed
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the 9009-pipx-fix-global branch November 2, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug integration tests/integration module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipx: Injecting packages fails when using global
3 participants
@russoz @felixfontein @ansibullbot