Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'CapacityBytes' from list of required parameters #8956

Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- redfish_confg - remove ``CapacityBytes`` from required paramaters of the ``CreateVolume`` command (https://github.com/ansible-collections/community.general/pull/8956).
4 changes: 2 additions & 2 deletions plugins/module_utils/redfish_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3774,8 +3774,8 @@ def create_volume(self, volume_details, storage_subsystem_id):
'msg': "Provided Storage Subsystem ID %s does not exist on the server" % storage_subsystem_id}

# Validate input parameters
required_parameters = ['RAIDType', 'Drives', 'CapacityBytes']
allowed_parameters = ['DisplayName', 'InitializeMethod', 'MediaSpanCount',
required_parameters = ['RAIDType', 'Drives']
allowed_parameters = ['CapacityBytes', 'DisplayName', 'InitializeMethod', 'MediaSpanCount',
'Name', 'ReadCachePolicy', 'StripSizeBytes', 'VolumeUsage', 'WriteCachePolicy']

for parameter in required_parameters:
Expand Down
3 changes: 3 additions & 0 deletions plugins/modules/redfish_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@
required: false
description:
- Setting dict of volume to be created.
- If CapacityBytes key is not specified in this dictionary, the size of
the volume will be determined by the Redfish service. It's possible the
felixfontein marked this conversation as resolved.
Show resolved Hide resolved
size will not be the maximum available size.
type: dict
default: {}
version_added: '7.5.0'
Expand Down