Disk description now contains a StorageId and a RedfishURI #8937
Conversation
ansibullbot
added
feature
| @@ -911,6 +913,7 @@ def get_disk_inventory(self, systems_uri): | |||
| drive_result[property] = data[property] | |||
| drive_results.append(drive_result) | |||
| drives = {'Controller': controller_name, | |||
| 'StorageId': storage_id, | |||
There was a problem hiding this comment.
It might be worth adding "RedfishURI" for the Storage resource in addition to "StorageId" since there can be different storage subsystems across multiple systems with the same "Id" property. For example, these URIs are all unique Storage resources, but they all have "1" for the Id property...
/redfish/v1/Systems/RackMount1/Storage/1
/redfish/v1/Systems/RackMount2/Storage/1
/redfish/v1/Systems/RackMount3/Storage/1
There was a problem hiding this comment.
@mraineri , Thank you for your review, I understand, but i have a question:
My will here is to have a storage_subsystem_id to give to the CreateVolume command of community.general.redfish_config.
In your case what storage_subsystem_id would you provide to the command ?
There was a problem hiding this comment.
Ah, specifically with CreateVolume, "resource_id" is already used to point to a specific system if needed. So, at least for your usage, it's not needed today; the combination of "resource_id" and "storage_subsystem_id" will guarantee uniqueness.
Okay, so this isn't necessary at this time based on the current interfaces.
felixfontein
added
check-before-release
|
shipit |
felixfontein
removed
the
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8942 🤖 @patchback |
* Disks controller is now uniquely identified by the controller ID * Fix typo `StorageID` to `StorageId` * Add changelog fragments --------- Co-authored-by: Pierre-yves FONTANIERE <[email protected]> (cherry picked from commit 84e0190)
…a StorageId and a RedfishURI (#8942) Disk description now contains a StorageId and a RedfishURI (#8937) * Disks controller is now uniquely identified by the controller ID * Fix typo `StorageID` to `StorageId` * Add changelog fragments --------- Co-authored-by: Pierre-yves FONTANIERE <[email protected]> (cherry picked from commit 84e0190) Co-authored-by: Pierre-yves Fontaniere <[email protected]>
…ollections#8937) * Disks controller is now uniquely identified by the controller ID * Fix typo `StorageID` to `StorageId` * Add changelog fragments --------- Co-authored-by: Pierre-yves FONTANIERE <[email protected]>
SUMMARY
Add a
StorageIDto the drives description and aRedfishURIto each disk in the redfish_facts returned by the GetDiskInventory command.Fixes #8935
ISSUE TYPE
COMPONENT NAME
redfish_utils
ADDITIONAL INFORMATION
entries description before
{ "Controller": "HPE Smart Array P816i-a SR Gen10", "Drives": [ { "BlockSizeBytes": 512, "CapableSpeedGbs": 12, "CapacityBytes": 16000900661248, "EncryptionAbility": "None", "FailurePredicted": false, "HotspareType": "None", "Id": "16", "Identifiers": [ { "DurableName": "5000039D28430101", "DurableNameFormat": "NAA" } ], "MediaType": "HDD", "Model": "MB016000JZYVQ", "Name": "16TB 12G SAS HDD", "PhysicalLocation": { "PartLocation": { "LocationOrdinalValue": 1, "LocationType": "Bay", "ServiceLabel": "Slot=12:Port=1I:Box=1:Bay=1" } }, "Protocol": "SAS", "Revision": "HPD4", "RotationSpeedRPM": 7200, "SerialNumber": "34K0A0LCFU8H", "Status": { "Health": "OK", "State": "Enabled" }, "Volumes": [ "/redfish/v1/Systems/1/Storage/DE07A000/Volumes/129" ] } ] }And after
{ "Controller": "HPE Smart Array P816i-a SR Gen10", "Drives": [ { "BlockSizeBytes": 512, "CapableSpeedGbs": 12, "CapacityBytes": 16000900661248, "EncryptionAbility": "None", "FailurePredicted": false, "HotspareType": "None", "Id": "16", "Identifiers": [ { "DurableName": "5000039D28430101", "DurableNameFormat": "NAA" } ], "MediaType": "HDD", "Model": "MB016000JZYVQ", "Name": "16TB 12G SAS HDD", "PhysicalLocation": { "PartLocation": { "LocationOrdinalValue": 1, "LocationType": "Bay", "ServiceLabel": "Slot=12:Port=1I:Box=1:Bay=1" } }, "Protocol": "SAS", "RedfishURI": "/redfish/v1/Systems/1/Storage/DE07A000/Drives/16", "Revision": "HPD4", "RotationSpeedRPM": 7200, "SerialNumber": "34K0A0LCFU8H", "Status": { "Health": "OK", "State": "Enabled" }, "Volumes": [ "/redfish/v1/Systems/1/Storage/DE07A000/Volumes/129" ] } ], "StorageID": "DE07A000" }