Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #8887/0bc5f248 backport][stable-9] one_service: fix recreation #8932

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[PR #8887/0bc5f248 backport][stable-9] one_service: fix recreation #8932

merged 1 commit into from
Sep 26, 2024

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 26, 2024

This is a backport of PR #8887 as merged into main (0bc5f24).

SUMMARY

After some investigation i concluded that the problem described in the related issue can be fixed by changing one if-statement

Fixes #3137

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

one_service

ADDITIONAL INFORMATION

I also deleted a space between a function and a body because in all other functions there is no

# Now this should work as intented
- name: Instantiating OpenNebula service
  ansible.community.one_service:
    template_id: "{{ one_template_id }}"
    service_name: "{{ deployment_name }}"
    unique: true
    wait: true

@abakanovskii @patchback
one_service: fix recreation (#8887)
845f683 
* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment

(cherry picked from commit 0bc5f24)
@patchback patchback bot mentioned this pull request Sep 26, 2024
Merged
@ansibullbot
Copy link
Collaborator

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @xorel
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 26, 2024
@felixfontein felixfontein merged commit 993d580 into stable-9 Sep 26, 2024
149 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-9/0bc5f24863e98d153f89636193bba808b1f54e89/pr-8887 branch September 26, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @abakanovskii