CmdRunner: missing parameter for get_best_parsable_locale()

[russoz]

SUMMARY

Function call was missing a parameter

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

plugins/module_utils/cmd_runner.py

[patchback]

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4700acc on top of patchback/backports/stable-8/4700accbff826ae9e393dc6c01914a80a85ea2d1/pr-8929

Backporting merged PR #8929 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.general.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-8/4700accbff826ae9e393dc6c01914a80a85ea2d1/pr-8929 upstream/stable-8

4. Now, cherry-pick PR CmdRunner: missing parameter for get_best_parsable_locale() #8929 contents into that branch:

   $ git cherry-pick -x 4700accbff826ae9e393dc6c01914a80a85ea2d1

   If it'll yell at you with something like fatal: Commit 4700accbff826ae9e393dc6c01914a80a85ea2d1 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 4700accbff826ae9e393dc6c01914a80a85ea2d1

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR CmdRunner: missing parameter for get_best_parsable_locale() #8929 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-8/4700accbff826ae9e393dc6c01914a80a85ea2d1/pr-8929

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@russoz thanks for fixing this!

[patchback]

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/4700accbff826ae9e393dc6c01914a80a85ea2d1/pr-8929

Backported as #8930

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.