10.0.0: CmdRunner: remove deprecated feature #8928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russoz
changed the title
ansibullbot
added
WIP
felixfontein
added
the
breaking_change
felixfontein
changed the title
russoz
changed the title
|
The change looks good, but it needs a changelog fragment :) |
|
That was fast |
felixfontein
approved these changes
Sep 26, 2024
|
I was waiting for CI to pass to take another look, and then I saw you asked for a review anyway ;) |
|
@russoz thanks! |
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
* remove deprecated feature * remove deprecated feature from tests as well * Adjust the integration test * add changelog frag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove deprecated feature from CmdRunner
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cmd_runner.py