Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keycloak_realm, add organizations_enabled #8927

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

kominoshja
Copy link
Contributor

SUMMARY

Add boolean parameter to enable organizations (still an experimental keycloak feature) feature toggling for keycloak

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.general.keycloak_realm

@kominoshja kominoshja changed the title Update keycloak_realm.py, add organizations_enabled Update keycloak_realm, add organizations_enabled Sep 25, 2024
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 25, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Sep 26, 2024
@russoz
Copy link
Collaborator

russoz commented Sep 26, 2024

Hi @kominoshja
Thank you for the contribution! Please add a changelog fragment.

@russoz
Copy link
Collaborator

russoz commented Sep 26, 2024

Is the new option being consumed within the code directly from the module? I have not opened the whole file and won't be able to spend much time on it these days, but it looks like the new option is not used.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/keycloak_realm.py Show resolved Hide resolved
@felixfontein felixfontein removed the backport-9 Automatically create a backport for the stable-9 branch label Oct 7, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 7, 2024
@kominoshja
Copy link
Contributor Author

Hey, sorry for the slow turnaround on my end, I've now added the changelog_fragment (Hope I got it right), and have also accepted @felixfontein's suggestion.

Thank you all for the great work you do in maintaining these Ansible collections. With ❤️
Boris

@kominoshja
Copy link
Contributor Author

Is the new option being consumed within the code directly from the module? I have not opened the whole file and won't be able to spend much time on it these days, but it looks like the new option is not used.

It gets consumed by the code yes (organization_enabled is the key for this value in KC's api), so all I had to do was add it as another item in the meta_args dict

@ansibullbot ansibullbot added has_issue and removed stale_ci CI is older than 7 days, rerun before merging labels Oct 14, 2024
@kominoshja
Copy link
Contributor Author

Is the new option being consumed within the code directly from the module? I have not opened the whole file and won't be able to spend much time on it these days, but it looks like the new option is not used.

It gets consumed by the code yes (organization_enabled is the key for this value in KC's api), so all I had to do was add it as another item in the meta_args dict

I also bumped added_version to 9.6.0 since .5 was already released

@russoz
Copy link
Collaborator

russoz commented Oct 15, 2024

I also bumped added_version to 9.6.0 since .5 was already released

9.5.0 is the last of its line and bears no heirs. Please bump it to 10.0.0 ;-)

(you can keep track of that at: #582 )

@kominoshja
Copy link
Contributor Author

Thanks for the pointer, edited :)

@felixfontein
Copy link
Collaborator

9.5.0 is the last of its line and bears no heirs. Please bump it to 10.0.0 ;-)

That's not completely true, there will be further 9.5.x bugfix releases, but no more 9.x.0 minor releases. So for new features it will be 10.0.0 (or later), but there will still be (bugfix release) heirs to 9.5.0 ;)

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change left from my side:

@russoz
Copy link
Collaborator

russoz commented Oct 21, 2024

9.5.0 is the last of its line and bears no heirs. Please bump it to 10.0.0 ;-)

That's not completely true, there will be further 9.5.x bugfix releases, but no more 9.x.0 minor releases. So for new features it will be 10.0.0 (or later), but there will still be (bugfix release) heirs to 9.5.0 ;)

C'mon I was trying to sound dramatic.

Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 21, 2024
@felixfontein felixfontein merged commit a8c41ac into ansible-collections:main Oct 21, 2024
126 checks passed
@felixfontein
Copy link
Collaborator

@kominoshja thanks for your contribution!
@russoz thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_issue module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants