-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keycloak_realm, add organizations_enabled #8927
Conversation
Hi @kominoshja |
Is the new option being consumed within the code directly from the module? I have not opened the whole file and won't be able to spend much time on it these days, but it looks like the new option is not used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Co-authored-by: Felix Fontein <[email protected]>
Add changelog file
Hey, sorry for the slow turnaround on my end, I've now added the changelog_fragment (Hope I got it right), and have also accepted @felixfontein's suggestion. Thank you all for the great work you do in maintaining these Ansible collections. With ❤️ |
It gets consumed by the code yes (organization_enabled is the key for this value in KC's api), so all I had to do was add it as another item in the meta_args dict |
I also bumped added_version to 9.6.0 since .5 was already released |
9.5.0 is the last of its line and bears no heirs. Please bump it to 10.0.0 ;-) (you can keep track of that at: #582 ) |
Thanks for the pointer, edited :) |
That's not completely true, there will be further 9.5.x bugfix releases, but no more 9.x.0 minor releases. So for new features it will be 10.0.0 (or later), but there will still be (bugfix release) heirs to 9.5.0 ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change left from my side:
changelogs/fragments/9027-support-organizations-in-keycloak-realm.yml
Outdated
Show resolved
Hide resolved
C'mon I was trying to sound dramatic. |
…alm.yml Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kominoshja thanks for your contribution! |
SUMMARY
Add boolean parameter to enable organizations (still an experimental keycloak feature) feature toggling for keycloak
ISSUE TYPE
COMPONENT NAME
community.general.keycloak_realm