proxmox inventory: remove duplicated credentials line #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
Thanks for your contribution! Can you add a changelog fragment, something along |
felixfontein
added
check-before-release
|
Ok, done. |
felixfontein
approved these changes
Sep 25, 2024
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8919 🤖 @patchback |
|
@perfide thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line (cherry picked from commit 89ad40d)
felixfontein
pushed a commit
that referenced
this pull request
Sep 25, 2024
…icated credentials line (#8919) proxmox inventory: remove duplicated credentials line (#8917) * proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line (cherry picked from commit 89ad40d) Co-authored-by: Per Fide <[email protected]>
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
…tions#8917) * proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line * fixup! proxmox inventory: remove duplicated credentials line
felixfontein
removed
the
check-before-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
credentialsvariable has been declared twice, but is only needed in the password-auth-if-block.The change has no functional impact and therefore I did not add a changelog fragment:
ISSUE TYPE
COMPONENT NAME
proxmox
ADDITIONAL INFORMATION
The line had been cloned when token-support has been added with #4540