one_host: Fix ID logic

[abakanovskii]

SUMMARY

Fix if statements when ID equals to 0

Fixes #1199

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

one_host

ADDITIONAL INFORMATION

So I tested all of the one. commands and It seem to be returning ID (integer) of created/updated host or cluster
So using simple if some_variable: will not work if ID=0 because bool(0) = False and since and since OpenNebula starts ID counter from zero thats a big problem

# Now this works if ID is 0
    - name: Add host to OpenNebula
      community.general.one_host:
        api_url: "{{ one_api_url }}"
        api_username: "{{ one_api_username }}"
        api_password: "{{ one_api_password }}"
        name: "{{ one_host }}"
        im_mad_name: kvm
        vmm_mad_name: kvm
        template:
          TYPE: "testing"
        state: present

[ansibullbot]

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @rvalle @xorel
click here for bot help

[russoz]

Just to be on the safe side, have you checked whether the other if statements you are modifying do not fall under the same situation?
Methods:

• one.host.status()
• one.host.delete()
• one.host.update()
• one.host.addhost()
  Don't they also trigger exceptions when parameters are invalid?

[abakanovskii]

they are all almost the same in terms of error handling but it seems to me that other if statements look right

here are 2 examples for one.host.status(), 1 when running with no parameters, 2 when running with wrong parameter

[russoz]

So, in that case, wouldn't it be good to add the try-except around them below as well?

[abakanovskii]

Could you please show which if statemets are wrong as well? From my perspective other if statements look right

[russoz]

I would not go as far as saying they are wrong, but the same way that you transformed the if statement into a try-except, maybe those could benefit from that as well - line numbers on your branch (right hand side):

• line 229
• line 245
• line 259
• line 282
• line 291

[abakanovskii]

oops, I completely missed them, thanks!

[russoz]

Beware that by using this, we are assuming that those calls will raise exceptions when failing (which makes sense, but not all developers write code that way). I would suggest you confirm that if you haven't yet.

Other than that, LGTM.

[abakanovskii]

yeah, it's too much IMO, no need to use it for every call :)
I simply do not use this module that much, so if one day I would need to use this module directly then might as well check if these are necessary

[russoz]

LGTM

[russoz]

LGTM

[russoz]

I did hit the button twice by mistake. 🤦

[patchback]

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/8df9d0d7dee12391a65b868d390b2dcd3e3803c6/pr-8907

Backported as #9014

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@abakanovskii thanks for your contribution!
@russoz thanks for reviewing!